[ 
https://issues.apache.org/jira/browse/SYSTEMML-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730229#comment-15730229
 ] 

Deron Eriksson commented on SYSTEMML-1139:
------------------------------------------

Thank you [~niketanpansare] for updating the related documentation with 
https://github.com/apache/incubator-systemml/commit/bf42a91d208b2a8f95468ce86c587a584f7287c1

> Tighten maven integration for python artifact
> ---------------------------------------------
>
>                 Key: SYSTEMML-1139
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-1139
>             Project: SystemML
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Deron Eriksson
>            Assignee: Deron Eriksson
>             Fix For: SystemML 1.0
>
>
> To integrate cleanly with our maven-based build system, the python artifact 
> could use the following enhancements:
> 1) bind to package phase (in the distribution profile) rather than 
> post-integration-test phase so 'mvn clean package -P distribution' will build 
> the python artifact along with the other distribution artifacts
> 2) python artifact should end up in target directory so that it is in the 
> expected location for generated maven artifacts
> 3) since python is being run under src/, clean up temporary files under src/ 
> used to create the artifact (this is preferred to gitignoring them)
> 4) 'mvn clean' should remove the artifact
> 5) artifact version number (and name) should ideally be coming from pom.xml 
> file to eliminate the need to manage an additional version number in setup.py
> 6) update license to include wink and antlr licenses since they are included 
> in the SystemML.jar within the python artifact



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to