Deron Eriksson created SYSTEMML-1173:
----------------------------------------

             Summary: DataExpression and StringIdentifier toString readability
                 Key: SYSTEMML-1173
                 URL: https://issues.apache.org/jira/browse/SYSTEMML-1173
             Project: SystemML
          Issue Type: Improvement
          Components: Parser
            Reporter: Deron Eriksson
            Assignee: Deron Eriksson
            Priority: Minor


Improve readability of StringIdentifier and DataExpression toString methods.

For example, `A = matrix("1 2 3 4 5 6", rows=3, cols=2)` in a DMLProgram 
results in:
{code}
A = RAND(,lambda=1.0,min=1 2 3 4 5 6,pdf=uniform,seed=-1,max=1 2 3 4 5 
6,sparsity=1.0,rows=3,cols=2 );
{code}

The extraneous first comma within RAND is confusing. Additionally, the string 
'1 2 3 4 5 6' is not surrounded by quotes, which affects readability.

Readability is improved if the toStrings are modified to produce output such as 
the following:
{code}
A = RAND(lambda=1.0, min='1 2 3 4 5 6', pdf='uniform', seed=-1, max='1 2 3 4 5 
6', sparsity=1.0, rows=3, cols=2);
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to