[
https://issues.apache.org/jira/browse/SYSTEMML-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000196#comment-16000196
]
Matthias Boehm commented on SYSTEMML-1527:
------------------------------------------
yes, you could simply (1) delete ./src/test/scripts/applications/glm/GLM.dml,
(2) modify test.integration.applications.GLMTest to point to
{{fullDMLScriptName = "scripts/algorithms/GLM.dml"}} if the script type is dml,
and (3) modify the R script if needed. Other algorithms might also require to
change the input parameters from positional arguments to named arguments.
I would recommend to first handle all dml scripts and disregard pydml for now.
Furthermore, you might want to think about a nice abstraction such as
{{AutomatedTestBase.getScript()}} to ensure consistency across the algorithms.
> Use top-level algorithm scripts for application tests
> -----------------------------------------------------
>
> Key: SYSTEMML-1527
> URL: https://issues.apache.org/jira/browse/SYSTEMML-1527
> Project: SystemML
> Issue Type: Sub-task
> Components: Test
> Reporter: Matthias Boehm
>
> There are numerous dml and pydml application tests that aim to test our
> existing algorithms. However, these tests use replicated (and mostly
> outdated) scripts. This task aims to remove the duplicated dml and pydml
> scripts and to refer directly to the existing algorithm tests. This also
> includes the update of R comparison scripts.
> See SYSTEMML-1363 for examples.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
