-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18678/
-----------------------------------------------------------
(Updated March 25, 2014, 10:45 a.m.)
Review request for Tajo.
Changes
-------
The latest patch allows upper/lower mxed case identifiers with double quote.
Bugs: TAJO-644
https://issues.apache.org/jira/browse/TAJO-644
Repository: tajo
Description
-------
In SQL standards, non-ascii identifiers are supported by using double quotation
as follows:
{code}
SELECT a, b, "?", d from table1
{code}
We should support quoted identifiers.
Diffs (updated)
-----
CHANGES.txt 7b379b31c1fc3b594a0f18b728aee60dd98c2745
tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnReferenceExpr.java
e1369df0b1fb670c69445d2c3e89c5d116fd2671
tajo-algebra/src/main/java/org/apache/tajo/algebra/QualifiedAsteriskExpr.java
ab8e6778950e70f10518da0d6c5fa2e47b034f2e
tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
6ee788ce6cae18b064016a539606113522e68f97
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
05a18bde0e951b5c4aeb7bf64d655b8a42979896
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java
b75cd1cedafdcdabc9a615eb5625629b0db13fd0
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java
ef65b3601c7b619f8b707b35bf81174f90783360
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
0c812f178d92b091d18404f5fb16624101d36d90
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java
30102eb12046c7d37e5737d7fa2514fcb8733c6a
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
50726a6ff4a6ef2f332c90a1cf612b711b034676
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
d4ee769de95c93436918fecfadb183aa90297293
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
98c289e42f0ea44f2671772b649fad2b228329a2
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
9fc9d2af50764611e4bea66a6094fb76b930c570
tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
bf77f030257416bd655a3ad4713e4eddf22a87df
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLLexer.g4
8eba9a4c447edc31f6827cea8ce44ae4ce57ab0c
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4
8966fd38b77dc202e25f0e157969911e51a87ccb
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
4dada453c4c94671a5de66369f5816cb24bfa3bf
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java
c3bca66b56e23623645038adf68bae5e692a67eb
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/NamedExprsManager.java
33f6fc6c685626727a936d2a262d27b66de87881
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/Target.java
d83a3945b50d4b636a9eb9679373ac10d805f69c
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/ScanNode.java
8e4911f9e665f06a66ea74f4ec54e2e8a3418593
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/TableSubQueryNode.java
26520302554c1403bbea46ebf083deb12aaebaba
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/query/QueryContext.java
5076b87d8f821a734ef8ecab12251df00e227425
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java
d0e8dc44ccf13b620c9fa441aca0030cbb92b1a2
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
a504e7b8a2acae3f7b277a9daf96d2fff689f3de
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java
a5c5d78d76203961766cb31a862b500ab607936a
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestTajoClient.java
5949d1b1d2405257b9666c7982e00a7e24bc87dc
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
a89f2bbb10c08cbadd7f328d7829a4681bb02d5d
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java
39c7492891f1b6bb98a3acb34d9d9d6ff10849cd
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
a7b0a9eacd8e7b5be106403d0ab677e32d0a198a
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java
b882e844243dad4511ed7c11a7b2b7e23b035789
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestLogicalOptimizer.java
c4ef32b750cb9787902461b2d04f516b4ef6fa23
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
65ade682065adb4b9a05cdac0891a596a88d43ed
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestPlannerUtil.java
a44f5f730eae49cb7a48916b21d05cfc68058a7e
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java
7092693c79ca1725e0c5085de4310a8669997796
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java
bce9d8e355ce7505b0a6299f136c939c5a0d4c93
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java
a82eeb90a8dcec581f00655bf607a7c2386abc2b
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java
9d0a86a484b3d8998236a18d4c8c7bfc44090ed2
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java
da7fce025ce6a7ae53c491cecd8abad6e38dbf2e
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
75a27db9e5f7c08ca836dc52df2c5a28dd2c21d5
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java
2ed057c7e6509063818369dc054b2fbddb2465e8
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java
7fdfb44c34158984dcf8ae2ef0a616f52eaa1ed3
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
c7aa33d04392211c56d24a81dbd748738087fac7
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java
65b5dba51a57d7f9d19cca733244149042483bf9
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java
a33a0e4e4eeda2bd4d1c1709ffaf55f25a2cd800
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
79db68cd6363c8dc0f0a95eaa35b64f64d8c028d
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateDatabase.java
c1c2591fcbac7f7de7808c2570da60974934cb22
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
f2882dd8aecc0544db5e9afd60bd4bb8382117fd
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java
250be472c95a9a01718b2aa2da73905813ed9a57
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
a53fff726107d1da62fa6cf782c24a71eb30f252
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
1279245b6cc3aa5c75c01af3a537dcac2f8b3f00
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/master/querymaster/TestQueryUnitStatusUpdate.java
ddf8ecb83e85b5d8c2b2e392b7fce4b7f7bf704b
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java
0b3a22c654a6462e1b6be7ab92609dce7cde07a5
tajo-core/tajo-core-backend/src/test/resources/dataset/TestCreateTable/table2/table2.tbl
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/org/apache/tajo/jdbc/TestTajoResultSet.java
92a8a6a0e40813d3af5c8fcfbd43ae84f3639ab0
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_identifier_mixed_chars_1.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_identifier_mixed_chars_2.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_identifier_mixed_chars_3.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_identifier_mixed_chars_ddl_1.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_identifier_mixed_chars_ddl_2.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_identifier_non_ascii_1.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_identifier_non_ascii_2.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_identifier_non_ascii_3.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_identifier_non_ascii_ddl.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestCreateTable/quoted_identifier_mixed_chars_1.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestCreateTable/quoted_identifier_mixed_chars_2.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestCreateTable/quoted_identifier_mixed_chars_3.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestCreateTable/quoted_identifier_non_ascii_1.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestCreateTable/quoted_identifier_non_ascii_2.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestCreateTable/quoted_identifier_non_ascii_3.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestTajoJdbc/getTables1.result
88df9a8fac753d88fa8a761f8d5ab869c3c862a4
tajo-core/tajo-core-backend/src/test/resources/results/TestTajoJdbc/getTables2.result
06afed273886f3e28e1031eacb00cc37bb782e7a
tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java
f70b762ba7cea3265586cc7c91427c780b3b3a62
Diff: https://reviews.apache.org/r/18678/diff/
Testing
-------
mvn clean install
Thanks,
Hyunsik Choi
