----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19513/#review38444 -----------------------------------------------------------
Ship it! +1. This patch looks good to me. Thanks for your contribution, Alvin! - Jihoon Son On March 24, 2014, 8:42 a.m., Alvin Henrick wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19513/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 8:42 a.m.) > > > Review request for Tajo and Hyunsik Choi. > > > Bugs: TAJO-684 > https://issues.apache.org/jira/browse/TAJO-684 > > > Repository: tajo > > > Description > ------- > > Add functions about time > > > Diffs > ----- > > tajo-common/src/main/java/org/apache/tajo/util/TimeStampUtil.java > PRE-CREATION > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/datetime/DateTimePartFromUnixTimeStamp.java > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestDateTimeFunctions.java > b882e84 > > Diff: https://reviews.apache.org/r/19513/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > TAJO-684-Patch > > https://reviews.apache.org/media/uploaded/files/2014/03/21/c8117c71-5a01-495d-ae9b-eb78d43f323a__TAJO-684-With-ASF-Unit-Test.patch > > > Thanks, > > Alvin Henrick > >
