-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19685/
-----------------------------------------------------------
(Updated March 26, 2014, 2:31 p.m.)
Review request for Tajo and Hyunsik Choi.
Changes
-------
uploading patch
Bugs: TAJO-480
https://issues.apache.org/jira/browse/TAJO-480
Repository: tajo
Description
-------
1) Implemented Alter Table.
2) Made changes to various component like algebra,parser,catalog,planner and
engine etc.
3) Only implemented MemStore for review.Before I proceed any further felt like
it needs to be reviewed.
4) Need to implement AbstractDBStore.WIP
5) Need to improve exception handling and logging.WIP.
Please feel free to advice comment. Appreciate your help in reviewing the code.
Thanks!
Warm Regards,
Alvin.
Diffs (updated)
-----
tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java
PRE-CREATION
tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java
PRE-CREATION
tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java 7122af8
tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
1932db5
tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogService.java
494ac0b
tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto 6a96b4e
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
PRE-CREATION
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java
PRE-CREATION
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
2a6727e
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/ColumnNameAlreadyExistException.java
PRE-CREATION
tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto 35171cc
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
621b475
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
ef485ef
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
db15c02
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
1fef286
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4
1ceaca8
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
71c16f2
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
af7c3e9
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java
acb9008
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
cf36539
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java
94e2482
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java
b08109d
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVisitor.java
bf41996
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
01bacc0
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
a928fb5
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/SimpleAlgebraVisitor.java
dc7b7a2
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java
PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/NodeType.java
acaf85b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java
d7ded93
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java
ddb9952
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/dataset/TestAlterTable/table1.tbl
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_add_new_column_ddl.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_column_ddl.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_table_ddl.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/table1_ddl.sql
PRE-CREATION
Diff: https://reviews.apache.org/r/19685/diff/
Testing
-------
Thanks,
Alvin Henrick
