----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19721/#review38883 -----------------------------------------------------------
Ship it! +1 Looks great for me. I've verified 'mvn clean install'. - Jinho Kim On March 27, 2014, 12:01 p.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19721/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 12:01 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-718 > https://issues.apache.org/jira/browse/TAJO-718 > > > Repository: tajo > > > Description > ------- > > The reproduction SQL statement is as follows: > {code} > SELECT > "lineitem".l_orderkey AS l_orderkey, > "lineitem".l_orderkey AS l_orderkey1, > COUNT ("lineitem".l_orderkey) AS T57801e5322bc50 > FROM > "lineitem" > GROUP BY > l_orderkey, l_orderkey1 > ORDER BY > l_orderkey, l_orderkey1; > {code} > > > Diffs > ----- > > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprNormalizer.java > 9c732b4 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java > c479f1c > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java > 4f3c6d4 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCaseByCases.java > 6472c68 > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCaseByCases/testTAJO718Case.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestCaseByCases/testTAJO718Case.result > PRE-CREATION > > Diff: https://reviews.apache.org/r/19721/diff/ > > > Testing > ------- > > mvn clean install -Phcatalog-0.12.0 > > > Thanks, > > Hyunsik Choi > >
