[
https://issues.apache.org/jira/browse/TAJO-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957910#comment-13957910
]
Hyunsik Choi commented on TAJO-709:
-----------------------------------
+1
The patch looks pretty nice to me. The readability is significantly improved,
and the script becomes more easy to use. Thank you for your work!
Actually, I haven't succeeded {{-pa}} command of this script even though the
command seems to work with the parameter in {{jiracli}. I added this command to
the script, but I don't think so anyone need this feature. So, I think that we
don't need to mind the feature, and I'm also Ok even if it is removed from the
script.
If you think that the patch is ready to commit, I'll commit it.
Best regards,
Hyunsik Choi
> Add .reviewboardrc and use rbt instead of post-review
> -----------------------------------------------------
>
> Key: TAJO-709
> URL: https://issues.apache.org/jira/browse/TAJO-709
> Project: Tajo
> Issue Type: Improvement
> Components: conf and scripts
> Reporter: David Chen
> Assignee: David Chen
> Priority: Minor
> Attachments: TAJO-709.patch
>
>
> The {{request-patch-review.py}} script uses the {{post-review}} tool to post
> a patch to Review Board, which is deprecated in favor of {{rbt}}. The
> instructions on setting up configuration for submitting posts is also
> slightly complex and can be made simpler by adding a {{.reviewboardrc}} to
> source control.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
