[
https://issues.apache.org/jira/browse/TAJO-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962573#comment-13962573
]
Hyunsik Choi commented on TAJO-215:
-----------------------------------
Hi [~alvinhenrick],
Thank you for your contribution. The patch looks nice for me. I leave some
comments.
I think that there are two find methods for exact matching and compatible
matching. The exact matching will be used to check if one creating function
already exists. The compatible match will be used to find functions used in
query processing.
The latest patch omits exact matching method and function existence check,
which should be performed when a function is created. Could you add both exact
matching method and function existence check? In addition, It would be great to
add unit tests which verify compatible functions.
Best regards,
Hyunsik
> Catalog should allow compatible types when finding functions
> ------------------------------------------------------------
>
> Key: TAJO-215
> URL: https://issues.apache.org/jira/browse/TAJO-215
> Project: Tajo
> Issue Type: Sub-task
> Components: catalog, function/udf
> Affects Versions: 0.8-incubating, 1.0-incubating
> Reporter: Hyunsik Choi
> Assignee: Alvin Henrick
> Priority: Critical
> Labels: patch
> Fix For: 0.8-incubating, 1.0-incubating
>
> Attachments: TAJO-215.Henrick.01.patch.txt,
> TAJO-215.Henrick.02.patch.txt, TAJO-215_2.patch
>
>
> Current catalog is strong typed. Given a find request, it only can search for
> a certain function with the same argument types. However, in many cases,
> catalog should find functions with compatible parameter types.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
