[
https://issues.apache.org/jira/browse/TAJO-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965026#comment-13965026
]
Tajo QA commented on TAJO-563:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12639536/TAJO-563.patch
against master revision d952b61.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:red}-1 tests included.{color} The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 205 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in
tajo-common tajo-core/tajo-core-backend.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/321//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/321//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/321//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/321//console
This message is automatically generated.
> INSERT OVERWRITE should not remove data before query success
> ------------------------------------------------------------
>
> Key: TAJO-563
> URL: https://issues.apache.org/jira/browse/TAJO-563
> Project: Tajo
> Issue Type: Bug
> Components: query master, tajo master
> Affects Versions: 0.8-incubating, 1.0-incubating
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Priority: Critical
> Fix For: 0.8-incubating
>
> Attachments: TAJO-563.patch
>
>
> INSERT OVERWRITE removes a table data set regardless of query success. In
> addition, INSERT OVERWRITE removes a table data set upon launching a query.
> It is a very dangerous approach, and we have to fix it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
