-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20199/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-745
https://issues.apache.org/jira/browse/TAJO-745
Repository: tajo
Description
-------
Identifiers that APIs in TajoClient and Tajo JDBC driver take are normalized in
client API side. So, identifiers composed of upper and lower mixed characters
should be used with double quote ("). This convention is different from
existing JDBC driver's convention. It makes ugly code when users use TajoClient.
This patch changes their APIs to be case sensitive. In addition, this patch
adds some missing JDBC APIs and fixes wrong behaviors of getTables() and
getColumns() in JDBC APIs.
Diffs
-----
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java
c695fc8
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
5bcb290
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java
2e29536
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
e6b0bcd
tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java 32d09df
tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java ad607a1
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/LikePredicateEval.java
e1c693e
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java
ed943f2
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
ad93738
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
a6bb467
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java
78714c5
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
6d72ca7
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java
PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
9d0352c
tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_table_ddl.sql
eeab457
tajo-core/tajo-core-backend/src/test/resources/results/TestTajoDatabaseMetaData/getTables1.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestTajoDatabaseMetaData/getTables2.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestTajoJdbc/getTables1.result
2d89f42
tajo-core/tajo-core-backend/src/test/resources/results/TestTajoJdbc/getTables2.result
042cb52
tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoConnection.java 5d967e8
tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java
ac122c8
tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDriver.java c537eb5
tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java b7604a8
Diff: https://reviews.apache.org/r/20199/diff/
Testing
-------
mvn clean install [passed]
mvn clean test -Phcatalog-0.12.0
-Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore [passed]
Thanks,
Hyunsik Choi
