[
https://issues.apache.org/jira/browse/TAJO-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hyunsik Choi updated TAJO-215:
------------------------------
Attachment: TAJO-215.Hyunsik.140410.patch
Hi [~alvinhenrick],
+1 for your latest patch.
I reviewed and tested all unit tests. The patch looks pretty nice to me. I had
some comments. It's for the use of integer constants in isCompatibleType() as
follows:
{code}
if (exitingTypeNumber >= 2 && exitingTypeNumber <= 6) {
// INT1 ==> INT2 ==> INT4 ==> INT8
if (argTypeNumber >= 2 && argTypeNumber <= exitingTypeNumber) {
flag = true;
}
}
{code}
I think that the direct use of integer constant may have some limit to change
the TajoDataType class generated by protocol buffer. But, it's very trivial, so
I've updated them rather than commenting it and waiting for your patch update.
In addition, I added one trivial change for ANY type in isCompatibleType, which
allows all data types. Also, I added its unit test in TestCatalog.
I hope that my update is matched to your intention. If you agree, I'll commit
it shortly.
Best regards,
Hyunsik
> Catalog should allow compatible types when finding functions
> ------------------------------------------------------------
>
> Key: TAJO-215
> URL: https://issues.apache.org/jira/browse/TAJO-215
> Project: Tajo
> Issue Type: Sub-task
> Components: catalog, function/udf
> Affects Versions: 0.8-incubating, 1.0-incubating
> Reporter: Hyunsik Choi
> Assignee: Alvin Henrick
> Priority: Critical
> Labels: patch
> Fix For: 0.8-incubating, 1.0-incubating
>
> Attachments: TAJO-215.Henrick.01.patch.txt,
> TAJO-215.Henrick.02.patch.txt, TAJO-215.Henrick.03.patch.txt,
> TAJO-215.Hyunsik.140410.patch, TAJO-215_2.patch
>
>
> Current catalog is strong typed. Given a find request, it only can search for
> a certain function with the same argument types. However, in many cases,
> catalog should find functions with compatible parameter types.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
