----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20253/#review40224 -----------------------------------------------------------
Ship it! +1 Thank you for you patch. This patch will be very useful to us. Push it. :) - Jung JaeHwa On April 11, 2014, 9:19 a.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20253/ > ----------------------------------------------------------- > > (Updated April 11, 2014, 9:19 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-755 > https://issues.apache.org/jira/browse/TAJO-755 > > > Repository: tajo > > > Description > ------- > > Currently, Tajo uses {{tajo.warehouse.directory}} to a default tablespace. > The default tablespace is stored to catalog server when TajoMaster starts up > firstly. > > Some users can change {{tajo.root}} after they use Tajo for a while. In this > case, the mismatch between {{tajo.root}} and the default space can cause some > problems. To avoid this confusion, we need to support {{ALTER TABLESPACE} to > change tablespaces > > > Diffs > ----- > > CHANGES.txt 9cdcb5e > tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTablespace.java > PRE-CREATION > > tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTablespaceSetType.java > PRE-CREATION > tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java 0cb0527 > > tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java > 60cce9a > > tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogService.java > f68f11a > tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto > 0f34f7c > tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto b985ba7 > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java > 755fca6 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java > b32b4e9 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java > b1efc7f > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java > e0c5a9d > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java > ca29a6b > > tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java > 1eefe29 > > tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 > 1249d57 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java > e95d5af > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java > 6aa4830 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlterTablespaceNode.java > PRE-CREATION > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java > 44adf12 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java > d569758 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java > 540d45b > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVisitor.java > 7f38026 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java > 6336f50 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java > 68578e8 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/NodeType.java > 375926e > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java > cbb8f37 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java > 5779347 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestAlterTablespace.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/20253/diff/ > > > Testing > ------- > > mvn clean install > mvn clean install -Phcatalog-0.12.0 > -Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore > > > Thanks, > > Hyunsik Choi > >
