[ 
https://issues.apache.org/jira/browse/TAJO-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974915#comment-13974915
 ] 

Hyunsik Choi edited comment on TAJO-777 at 4/19/14 6:21 PM:
------------------------------------------------------------

+1

Thank you for the bug fix. It's a nice finding. In addition, I found more cases 
similar to the bug you found. The cases were in BetweenPredicateEval, 
CaseWhenEval, IfElseEval, CastEval, NotEval, and SignedEval. So, I've updated 
your patch to include more bug fixes for them and the unit tests to reproduce 
the cases. 

If you agree with this patch or another committer throws +1, I'll commit it. 
Thanks!


was (Author: hyunsik):
+1

Thank you for the bug fix. It's a nice finding. In addition, I found more cases 
similar to the bug you found. The cases were in BetweenPredicateEval, 
CaseWhenEval, IfElseEval, CastEval, NotEval, and SignedEval. So, I've updated 
your patch to include more bug fixes for them and the unit tests to reproduce 
the cases. 

If you agree this patch, I'll commit it. Thanks!

> Partition column in function parameter occurs NPE
> -------------------------------------------------
>
>                 Key: TAJO-777
>                 URL: https://issues.apache.org/jira/browse/TAJO-777
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: Hyoungjun Kim
>            Assignee: Hyoungjun Kim
>            Priority: Minor
>         Attachments: TAJO-777.patch, TAJO-777_2.patch
>
>
> See the following case
> {noformat}
> create table testQueryCasesOnColumnPartitionedTable (col1 int4, col2 int4, 
> null_col int4) partition by column(key float8)
> select pow(key, 2) from testQueryCasesOnColumnPartitionedTable
> 2014-04-19 10:27:54,455 ERROR querymaster.QueryUnitAttempt 
> (QueryUnitAttempt.java:transition(405)) - FROM 192.168.0.11 >> 
> java.lang.NullPointerException
>       at 
> org.apache.tajo.engine.eval.EvalTreeUtil$EvalReplaceVisitor.visitChild(EvalTreeUtil.java:60)
>       at 
> org.apache.tajo.engine.eval.EvalTreeUtil$EvalReplaceVisitor.visitChild(EvalTreeUtil.java:44)
>       at 
> org.apache.tajo.engine.eval.BasicEvalNodeVisitor.visitDefaultFunctionEval(BasicEvalNodeVisitor.java:154)
>       at 
> org.apache.tajo.engine.eval.BasicEvalNodeVisitor.visitFuncCall(BasicEvalNodeVisitor.java:316)
>       at 
> org.apache.tajo.engine.eval.BasicEvalNodeVisitor.visitChild(BasicEvalNodeVisitor.java:121)
>       at 
> org.apache.tajo.engine.eval.EvalTreeUtil$EvalReplaceVisitor.visitChild(EvalTreeUtil.java:55)
>       at 
> org.apache.tajo.engine.eval.EvalTreeUtil.replace(EvalTreeUtil.java:41)
>       at 
> org.apache.tajo.engine.planner.physical.SeqScanExec.rewriteColumnPartitionedTableSchema(SeqScanExec.java:115)
>       at 
> org.apache.tajo.engine.planner.physical.SeqScanExec.init(SeqScanExec.java:131)
>       at 
> org.apache.tajo.engine.planner.physical.UnaryPhysicalExec.init(UnaryPhysicalExec.java:52)
>       at 
> org.apache.tajo.engine.planner.physical.StoreTableExec.init(StoreTableExec.java:49)
>       at org.apache.tajo.worker.Task.run(Task.java:383)
>       at org.apache.tajo.worker.TaskRunner$1.run(TaskRunner.java:391)
>       at java.lang.Thread.run(Thread.java:744)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to