[
https://issues.apache.org/jira/browse/TAJO-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hyunsik Choi updated TAJO-761:
------------------------------
Attachment: TAJO-761_6.patch
+1
It's awesome work. Even though the patch includes many changes, there are few
trivial comments. It also includes enough unit tests. It looks almost perfect
to me.
Since trivial change are required, I submitted the updated patch that reflects
them.
In detail, the changes of the last patch:
* removes commented out lines
* renames IntervalDatum::interval to milliseconds because the name 'interval'
seems duplicated to the class name.
* removes printStackTrace in legal exception handling
> Implements INTERVAL type
> ------------------------
>
> Key: TAJO-761
> URL: https://issues.apache.org/jira/browse/TAJO-761
> Project: Tajo
> Issue Type: Sub-task
> Reporter: Hyoungjun Kim
> Assignee: Hyoungjun Kim
> Attachments: TAJO-761.patch, TAJO-761_2.patch, TAJO-761_3.patch,
> TAJO-761_4.patch, TAJO-761_5.patch, TAJO-761_6.patch
>
>
> In order to provide the following features, INTERVAL Type is required.
> {noformat}
> babokim# select timestamp '2001-09-28 01:00' + interval '23 hours';
> ?column?
> ---------------------
> 2001-09-29 00:00:00
> (1 row)
> babokim=# select date '2001-10-01' - date '2001-09-28';
> ?column?
> ----------
> 3
> (1 row)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
