> On April 25, 2014, 4:42 p.m., Hyunsik Choi wrote: > > Could you check the patch? > > > > I simply tested as follows: > > > > default> \d > > default> ; > > default> \c; > > default> > > default> \d;\c;\l > > > > > > They all should work.
Thanks Hyunsik. I misunderstood the operation of ExecExternalShellCommand. I'll fix it and submit a new patch. - Jihoon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20653/#review41446 ----------------------------------------------------------- On April 24, 2014, 4:43 p.m., Jihoon Son wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20653/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 4:43 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-766 > https://issues.apache.org/jira/browse/TAJO-766 > > > Repository: tajo > > > Description > ------- > > In this test, the console message is checked, but it can be different > according to the system's language. > For example, the test is failed in my desktop because the console message is > in Korean. > > To handle this problem, I modified TajoCli.executeMetaCommand() to return -1 > when an exception occurs. > In addition, I fixed a bug in TajoCli, and improved ExecExternalSheelCommand > to print invalid commands. > > > Diffs > ----- > > tajo-client/src/main/java/org/apache/tajo/cli/ExecExternalShellCommand.java > ea2db28 > tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java 606ca88 > > tajo-core/src/test/java/org/apache/tajo/cli/TestExecExternalShellCommand.java > 9c6e760 > tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java 7acede6 > > Diff: https://reviews.apache.org/r/20653/diff/ > > > Testing > ------- > > mvn clean install > > > Thanks, > > Jihoon Son > >
