----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20763/#review41586 -----------------------------------------------------------
Ship it! +1 The patch looks good to me. - Hyunsik Choi On April 28, 2014, 3:22 p.m., Jinho Kim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20763/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 3:22 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-789 > https://issues.apache.org/jira/browse/TAJO-789 > > > Repository: tajo > > > Description > ------- > > Currently, shuffle uri use the string field. but most params is a number in > uri > We need change to Varint of protocol buffer. > https://developers.google.com/protocol-buffers/docs/encoding#varints > > > Diffs > ----- > > tajo-core/src/main/java/org/apache/tajo/engine/query/QueryUnitRequest.java > 383a787427bd63c9ea02e91e86c7235e61926f2a > > tajo-core/src/main/java/org/apache/tajo/engine/query/QueryUnitRequestImpl.java > d4006e03b74411b434a65e121876e2472dc05284 > tajo-core/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java > 99786708f6253c3b5bccadb819ded60e3d767e53 > tajo-core/src/main/java/org/apache/tajo/master/FetchScheduleEvent.java > 561f980d5a6c0d2630420898f5ba947330e43153 > tajo-core/src/main/java/org/apache/tajo/master/LazyTaskScheduler.java > dd82f283ca75b84217c88f144cdac5d1631e870b > tajo-core/src/main/java/org/apache/tajo/master/ScheduledFetches.java > 9b7dc229cf041807a50fad14c70b53a1d293aeb8 > tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java > 34686dac6b027249d047075c2f3bee7129f37288 > > tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java > b69742c53d96bfde69b67b52ff040278265ea613 > > tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java > 31d433d133e586a328413ac4069bfc73b8841d3e > tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java > 31c0efad6dd0850cc104b010f51f818dbca2fa76 > tajo-core/src/main/java/org/apache/tajo/worker/FetchImpl.java PRE-CREATION > tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java > bb136f7f4d351be1d04f7081d816dc9693d1f5b0 > tajo-core/src/main/java/org/apache/tajo/worker/Task.java > ef52fd07a3d49fd25ea89920820abb3c727b8d59 > tajo-core/src/main/proto/TajoWorkerProtocol.proto > 78da10fd814e373a9edb3af6cf081a05d7cbe33e > tajo-core/src/main/resources/webapps/worker/queryunit.jsp > 3e8dfefae82ffd7d57c05877ba30976ae3048306 > tajo-core/src/test/java/org/apache/tajo/master/TestRepartitioner.java > 987dc2a7242ed170272c41000dfb147ebb233ee9 > > Diff: https://reviews.apache.org/r/20763/diff/ > > > Testing > ------- > > > Thanks, > > Jinho Kim > >
