----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20661/#review41742 -----------------------------------------------------------
tajo-core/src/test/java/org/apache/tajo/master/TestGlobalPlanner.java <https://reviews.apache.org/r/20661/#comment75326> Preconditions will cause exception instead of test failure. It should be changed to use assertTrue. Before you commit it, please fix it. - Hyunsik Choi On April 28, 2014, 11:42 a.m., Jung JaeHwa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20661/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 11:42 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-795 > https://issues.apache.org/jira/browse/TAJO-795 > > > Repository: tajo > > > Description > ------- > > Currently, Tajo supports only equi-join, thus shuffle keys have to include > equi-jon conditions. But it includes theta-join conditions occasionally. We > need to update this bug, because tajo may be returned wrong row numbers. > Actually, I found that TPC-DS Q32 had returned unexpected results by this bug. > > > Diffs > ----- > > tajo-core/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java > 9f988bd > > tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java > edc08fc > tajo-core/src/test/java/org/apache/tajo/master/TestGlobalPlanner.java > 4d3b096 > > Diff: https://reviews.apache.org/r/20661/diff/ > > > Testing > ------- > > mvn clean install -Phcatalog-0.12.0 > > > Thanks, > > Jung JaeHwa > >
