> On May 14, 2014, 6:59 a.m., Jihoon Son wrote: > > Jinho, thanks for your great contribution! > > The patch looks good and passes all the unit tests, but I have a question. > > I think that we need to add a new QueryState for waiting queries in the > > scheduler. > > How do you think about it?
Thank you for the review!! This is just temporary solution, so I think that this should be simple implemention and this improvement may be deleted > On May 14, 2014, 6:59 a.m., Jihoon Son wrote: > > tajo-core/src/main/java/org/apache/tajo/scheduler/Schedulable.java, line 24 > > <https://reviews.apache.org/r/21264/diff/2/?file=581295#file581295line24> > > > > This is a very trivial comment. > > The name 'schedulable' looks the interface name, not class name. How > > about change it? OK, I'll change to QuerySchedulingInfo > On May 14, 2014, 6:59 a.m., Jihoon Son wrote: > > tajo-core/src/main/java/org/apache/tajo/scheduler/SchedulingAlgorithms.java, > > line 27 > > <https://reviews.apache.org/r/21264/diff/2/?file=581297#file581297line27> > > > > I think that there can be more proper class name such as FifoUtil. We can add other comparator, before TAJO-540 completed. - Jinho ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21264/#review42949 ----------------------------------------------------------- On May 14, 2014, 3:20 a.m., Jinho Kim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21264/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 3:20 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-811 > https://issues.apache.org/jira/browse/TAJO-811 > > > Repository: tajo > > > Description > ------- > > Currently, we don't support query scheduling. > Hyunsik and Min Zhou started to implement the tajo scheduler on TAJO-540. > It should be a big changes and there are many challenge. > This issue will be a temporary solution before TAJO-540 > > > Diffs > ----- > > tajo-client/src/main/java/org/apache/tajo/client/TajoAdmin.java > 9a0478cdad5428c15619729ab51e2b8a249c9345 > tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java > f6ad08547ac6f81048c0695cbdf7a915d473cb7c > > tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryInProgress.java > dac2d4c98ec9a7711d26fbb085cc1d2ae49c34e9 > > tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryJobManager.java > bc5fcadb1a143c5a9847cf60a7f6e369c041304f > tajo-core/src/main/java/org/apache/tajo/scheduler/Schedulable.java > PRE-CREATION > tajo-core/src/main/java/org/apache/tajo/scheduler/Scheduler.java > PRE-CREATION > tajo-core/src/main/java/org/apache/tajo/scheduler/SchedulingAlgorithms.java > PRE-CREATION > tajo-core/src/main/java/org/apache/tajo/scheduler/SimpleFifoScheduler.java > PRE-CREATION > tajo-core/src/main/resources/webapps/admin/query.jsp > 6f15a0e84250e16851761fd91885ec0a9afbd608 > tajo-core/src/test/java/org/apache/tajo/scheduler/TestFifoScheduler.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/21264/diff/ > > > Testing > ------- > > mvn clean install > local cluster > > > Thanks, > > Jinho Kim > >
