[ 
https://issues.apache.org/jira/browse/TAJO-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013197#comment-14013197
 ] 

ASF GitHub Bot commented on TAJO-846:
-------------------------------------

Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/20#discussion_r13213693
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/worker/TaskHistory.java 
---
    @@ -18,107 +18,160 @@
     
     package org.apache.tajo.worker;
     
    -import org.apache.tajo.catalog.statistics.TableStats;
    -import org.apache.tajo.util.FileUtil;
    +import com.google.common.base.Objects;
    +import com.google.common.collect.Lists;
    +import org.apache.tajo.QueryUnitAttemptId;
    +import org.apache.tajo.catalog.proto.CatalogProtos;
    +import org.apache.tajo.common.ProtoObject;
     
    -import java.net.URI;
    -import java.util.Collection;
    -import java.util.Map;
    +import java.util.Collections;
    +import java.util.List;
     
    -public class TaskHistory {
    +import static org.apache.tajo.TajoProtos.TaskAttemptState;
    +import static org.apache.tajo.ipc.TajoWorkerProtocol.FetcherHistoryProto;
    +import static org.apache.tajo.ipc.TajoWorkerProtocol.TaskHistoryProto;
    +
    +/**
    + * The history class for Task processing.
    + */
    +public class TaskHistory implements ProtoObject<TaskHistoryProto> {
    +
    +  private QueryUnitAttemptId queryUnitAttemptId;
    +  private TaskAttemptState state;
    +  private float progress;
       private long startTime;
       private long finishTime;
    -
    -  private String status;
    +  private CatalogProtos.TableStatsProto inputStats;
    +  private CatalogProtos.TableStatsProto outputStats;
       private String outputPath;
       private String workingPath;
    -  private float progress;
    -
    -  private TableStats inputStats;
    -  private TableStats outputStats;
     
    -  Map<URI, FetcherHistory> fetchers;
    +  //TAJO-846
    --- End diff --
    
    done


> Clean up the task history in woker
> ----------------------------------
>
>                 Key: TAJO-846
>                 URL: https://issues.apache.org/jira/browse/TAJO-846
>             Project: Tajo
>          Issue Type: Improvement
>          Components: worker
>    Affects Versions: 0.8.0, 0.9.0
>            Reporter: Jinho Kim
>            Assignee: Jinho Kim
>
> The task history currently store the thread in memory. it can’t store to 
> other storage(hdfs, local file ..). It would be nice if task history separate 
> from taskrunner



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to