> On June 11, 2014, 7:25 p.m., Hyunsik Choi wrote:
> > tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java,
> >  line 533
> > <https://reviews.apache.org/r/22374/diff/3/?file=607530#file607530line533>
> >
> >     Many of the parts seem to be similar to the codes of 
> > scheduleHashShuffledFetches. Is there any opportunity to make common 
> > methods?

Thanks Hyunsik.

I updated Repartitioner::scheduleHashShuffledFetches for handling scattered 
hash shuffle, and I removed Repartitioner:: 
scheduleScatteredHashShuffledFetches.


- Jung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22374/#review45415
-----------------------------------------------------------


On June 23, 2014, 3:05 a.m., Jung JaeHwa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22374/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 3:05 a.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-673
>     https://issues.apache.org/jira/browse/TAJO-673
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> When inserting into partitioned table, if the number of partitions is smaller 
> than cluster concurrency capacity, a query execution is too slow.
> 
> 
> Diffs
> -----
> 
>   tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java 3f2b16f 
>   
> tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
>  f41d61d 
>   
> tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
>  536dbd8 
>   
> tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java 
> 6c000a1 
>   tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java 
> 22817bd 
>   tajo-core/src/main/proto/TajoWorkerProtocol.proto 3bf6e13 
>   
> tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java 
> 0ec7de0 
>   
> tajo-core/src/test/resources/dataset/TestTablePartitions/customer_large/customer.tbl
>  PRE-CREATION 
>   
> tajo-core/src/test/resources/dataset/TestTablePartitions/lineitem_large/lineitem.tbl
>  PRE-CREATION 
>   
> tajo-core/src/test/resources/queries/TestJoinBroadcast/testBroadcastSubquery3.sql
>  PRE-CREATION 
>   
> tajo-core/src/test/resources/queries/TestTablePartitions/create_customer_large_ddl.sql
>  PRE-CREATION 
>   
> tajo-core/src/test/resources/queries/TestTablePartitions/create_lineitem_large_ddl.sql
>  PRE-CREATION 
>   
> tajo-core/src/test/resources/results/TestJoinBroadcast/testBroadcastSubquery3.result
>  PRE-CREATION 
>   
> tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java
>  b8fda29 
>   
> tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
>  cc3cb2e 
> 
> Diff: https://reviews.apache.org/r/22374/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> 
> Thanks,
> 
> Jung JaeHwa
> 
>

Reply via email to