Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/77#issuecomment-50131715
  
    Hi, @jihoonson 
    
    Thanks for your detailed review. I replied for your descriptions as follows:
    
    * I've just fixed NPE in the web UI via Hyunsik. Because my desktop has 
broken down.
    
    * DerbyStore is not appropriate for TajoMaster HA. As you know, just one 
tajo master invoke the store. If another master try to invoke it, it never run 
itself. Also, if we set another catalog uri for backup master, it is a 
incorrect configuration. Because they are unequal in every way.
    
    * If you run two masters on same host and you set same directory for pid, 
you must meet pid error. But I think that it is trivial problem. Because we can 
avoid easily by documents. 
    
    * If backup master become active, existing running query will finish 
successfully, and you will see success message in tsql. But you will never find 
executed query history in the web UI. Because TajoMaster contains its query 
history in memory, thus backup master can't know previous active master 
information. I already know this problem. And I'll save query simple history in 
share storage (like HDFS). 
    
     For reference, I'll write documents for TajoMaster HA. And I'll update 
start-tajo.sh to start backup masters. 
    
    Cheers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to