[ 
https://issues.apache.org/jira/browse/TAJO-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092593#comment-14092593
 ] 

ASF GitHub Bot commented on TAJO-895:
-------------------------------------

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/111#issuecomment-51757343
  
    This has some bug for window function.
    
    The reproduction query is as follows:
    ```
    select l_orderkey, l_quantity, rank() over (partition by l_orderkey) as r, 
5 as const_val from lineitem;
    ```
    
    This problem is caused by handling const values in a window clause. I'll 
submit the patch soon, including the fix of the problem.


> ConstEval should not be included in target list of projectable nodes
> --------------------------------------------------------------------
>
>                 Key: TAJO-895
>                 URL: https://issues.apache.org/jira/browse/TAJO-895
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.9.0
>
>
> In some applications, aliased constant values can be used in WHERE, GROUP BY, 
> HAVING, ORDER BY clauses. For those cases, current planner evaluates constant 
> value in target list of projectable nodes.
> {code}
> SELECT '1994' end as year, ... FROM lineitem WHERE group by year;
> {code}
> This approach works well so far, but there are rooms for significant 
> improvement.
> The main problem is that constant target requires many workaround code in 
> NamedExprManager, and TargetListManager. As a result, it makes code 
> complexity higher. The second problem is that many constant values evaluated 
> in each row consume unnecessary I/O and network bandwidth for storing and 
> transmitting.
> The solution seems to be simple. In logical planning phase, we should rewrite 
> column references which actually indicates constant values.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to