[ 
https://issues.apache.org/jira/browse/TAJO-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174853#comment-14174853
 ] 

ASF GitHub Bot commented on TAJO-235:
-------------------------------------

Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/154#discussion_r19006723
  
    --- Diff: 
tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/partition_methods.sql
 ---
    @@ -0,0 +1,7 @@
    +CREATE TABLE PARTITION_METHODS (
    +  TID INT NOT NULL PRIMARY KEY,
    +  PARTITION_TYPE VARCHAR2(10) NOT NULL,
    +  EXPRESSION VARCHAR2(1024) NOT NULL,
    +  EXPRESSION_SCHEMA VARCHAR2(1024) NOT NULL,
    --- End diff --
    
    I can't run TestCatalogStore. Could you change the EXPRESSION_SCHEMA type 
to binary type ?
    Additionally, please add the driverClass in 
TestCatalog.isConnectionIdRequired()
    
    ```
    Caused by: com.google.protobuf.InvalidProtocolBufferException: Protocol 
message tag had invalid wire type.
        at 
com.google.protobuf.InvalidProtocolBufferException.invalidWireType(InvalidProtocolBufferException.java:99)
        at 
com.google.protobuf.UnknownFieldSet$Builder.mergeFieldFrom(UnknownFieldSet.java:498)
        at 
com.google.protobuf.GeneratedMessage.parseUnknownField(GeneratedMessage.java:193)
        at 
org.apache.tajo.catalog.proto.CatalogProtos$SchemaProto.<init>(CatalogProtos.java:1617)
        at 
org.apache.tajo.catalog.proto.CatalogProtos$SchemaProto.<init>(CatalogProtos.java:1575)
        at 
org.apache.tajo.catalog.proto.CatalogProtos$SchemaProto$1.parsePartialFrom(CatalogProtos.java:1664)
        at 
org.apache.tajo.catalog.proto.CatalogProtos$SchemaProto$1.parsePartialFrom(CatalogProtos.java:1659)
        at 
com.google.protobuf.AbstractParser.parsePartialFrom(AbstractParser.java:141)
        at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:176)
        at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:188)
        at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:193)
        at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:49)
        at 
org.apache.tajo.catalog.proto.CatalogProtos$SchemaProto.parseFrom(CatalogProtos.java:1806)
        at 
org.apache.tajo.catalog.store.AbstractDBStore.resultToPartitionMethodProto(AbstractDBStore.java:1953)
        at 
org.apache.tajo.catalog.store.AbstractDBStore.getTable(AbstractDBStore.java:1295)
        ... 35 more
    ```


> Support Oracle CatalogStore
> ---------------------------
>
>                 Key: TAJO-235
>                 URL: https://issues.apache.org/jira/browse/TAJO-235
>             Project: Tajo
>          Issue Type: New Feature
>          Components: catalog
>            Reporter: Jinho Kim
>            Assignee: Jihun Kang
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.9.1
>
>
> Like TAJO-179, we need to support oracle catalog store.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to