[
https://issues.apache.org/jira/browse/TAJO-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206242#comment-14206242
]
ASF GitHub Bot commented on TAJO-1109:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/236#issuecomment-62527806
Excellent! Here is my +1.
I've just tested the patch on PostgreSQL and Derby. It works well, and the
patch looks nice to me. I'll commit the patch to master branch if there is no
objection until tomorrow.
FYI, this pull request continues to the following pull requests.
* https://github.com/apache/tajo/pull/216
* https://github.com/apache/tajo/pull/201
> Separate SQL Statements from Catalog Stores
> -------------------------------------------
>
> Key: TAJO-1109
> URL: https://issues.apache.org/jira/browse/TAJO-1109
> Project: Tajo
> Issue Type: Improvement
> Components: catalog
> Reporter: Jihun Kang
> Assignee: Jihun Kang
> Priority: Minor
> Fix For: 0.9.1
>
> Attachments: DBMSSchemaDefinition.xsd, derby.xml
>
>
> When developing the additional catalog stores for another database systems,
> it is needed to add additional sql statements such as triggers and indexes.
> These sql statements could increase the code size of catalog store, and when
> database schema has changed, it may affect the catalog store source codes. I
> feel that it is needed to separate the sql statements from the java source
> codes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
