Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/232#discussion_r20280308
--- Diff:
tajo-plan/src/main/java/org/apache/tajo/plan/logical/SortNode.java ---
@@ -25,10 +25,16 @@
import org.apache.tajo.util.TUtil;
public final class SortNode extends UnaryNode implements Cloneable {
+ public static enum SortRangeType {
+ USING_SHUFFLE_DATA,
--- End diff --
It's just my suggestion. If you agree, please reflect my suggestion.
You seem to add SortRangeType in order to identify the purpose of SortNode.
```USING_STORAGE_MANAGER``` is for sorting rows for sorted HFiles of Hbase.
Otherwise, ```USING_SHUFFLE_DATA``` will be used. BTW, ```USING_SHUFFLE_DATA```
is used for shuffle as well as just sort. Even shuffle is also a part of
distributed sort. So, I think that this names probably gives some confuse to
code readers.
So, I'd like to suggest as follows:
* SortRangeType -> SORT_PURPOSE
* USING_SHUFFLE_DATA -> NORMAL
* USING_STORAGE_MANAGER -> STORAGE_SPECIFIED
As I mentioned earlier, it's just my suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
