[ 
https://issues.apache.org/jira/browse/TAJO-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228032#comment-14228032
 ] 

ASF GitHub Bot commented on TAJO-1095:
--------------------------------------

Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/181#discussion_r21014823
  
    --- Diff: 
tajo-storage/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java
 ---
    @@ -0,0 +1,222 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.storage.json;
    +
    +
    +import io.netty.buffer.ByteBuf;
    +import net.minidev.json.JSONArray;
    +import net.minidev.json.JSONObject;
    +import net.minidev.json.parser.JSONParser;
    +import org.apache.tajo.catalog.Schema;
    +import org.apache.tajo.catalog.SchemaUtil;
    +import org.apache.tajo.catalog.TableMeta;
    +import org.apache.tajo.common.TajoDataTypes.Type;
    +import org.apache.tajo.common.exception.NotImplementedException;
    +import org.apache.tajo.datum.DatumFactory;
    +import org.apache.tajo.datum.NullDatum;
    +import org.apache.tajo.datum.protobuf.ProtobufJsonFormat;
    +import org.apache.tajo.storage.Tuple;
    +import org.apache.tajo.storage.text.TextLineDeserializer;
    +
    +import java.io.IOException;
    +import java.util.Iterator;
    +
    +public class JsonLineDeserializer extends TextLineDeserializer {
    +  private static ProtobufJsonFormat protobufJsonFormat = 
ProtobufJsonFormat.getInstance();
    --- End diff --
    
    Could you remove this line ? It seems to unused code


> Implement Json file scanner
> ---------------------------
>
>                 Key: TAJO-1095
>                 URL: https://issues.apache.org/jira/browse/TAJO-1095
>             Project: Tajo
>          Issue Type: New Feature
>          Components: storage
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.9.1
>
>
> Json file format is very common format in many web service applications. JSON 
> file support is very desired feature for users who want to analysis web data. 
> We also need to support this feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to