[
https://issues.apache.org/jira/browse/TAJO-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234931#comment-14234931
]
ASF GitHub Bot commented on TAJO-1213:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/285#discussion_r21351579
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
---
@@ -823,6 +823,74 @@ public void createTable(final
CatalogProtos.TableDescProto table) throws Catalog
}
@Override
+ public void updateTableStats(final CatalogProtos.UpdateTableStatsProto
statsProto) throws
+ CatalogException {
+ Connection conn = null;
+ PreparedStatement pstmt = null;
+ ResultSet res = null;
+
+ try {
+ conn = getConnection();
+ conn.setAutoCommit(false);
+
+ String[] splitted =
CatalogUtil.splitTableName(statsProto.getTableName());
+ if (splitted.length == 1) {
+ throw new IllegalArgumentException("createTable() requires a
qualified table name, but it is \""
--- End diff --
The exception message should be improved to print a proper function name.
> Implement CatalogStore::updateTableStats
> ----------------------------------------
>
> Key: TAJO-1213
> URL: https://issues.apache.org/jira/browse/TAJO-1213
> Project: Tajo
> Issue Type: Improvement
> Components: catalog
> Reporter: Jaehwa Jung
> Assignee: Jaehwa Jung
>
> Currently, there is no method to update existing table information at
> CatalogStore. So, if user execute an insert query, tajo drop a table and then
> tajo create a table. It doesn't matter to tajo own CatalogStore like
> DerbyStore, MySQLStore. But it is a critical issue to HCatalogStore. if tajo
> drop a existing partitioned table, users will lose existing partition
> informations. As a result, they should repair table partition against their
> will. As you know, hive msck command can affect hive metastore performance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
