[
https://issues.apache.org/jira/browse/TAJO-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237431#comment-14237431
]
ASF GitHub Bot commented on TAJO-1234:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/290#discussion_r21434576
--- Diff:
tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java ---
@@ -151,7 +150,7 @@ public final void testTimestampConstructor() {
assertEquals(datum2, datum);
for (int i = 0; i < 100; i++) {
- TimeZone timeZone = TimeZone.getTimeZone("UTC");
+ TimeZone timeZone = TimeZone.getTimeZone("GMT");
--- End diff --
How about using TajoConstants.UTC_TIMEZONE?
> Rearrange timezone in date/time types
> -------------------------------------
>
> Key: TAJO-1234
> URL: https://issues.apache.org/jira/browse/TAJO-1234
> Project: Tajo
> Issue Type: Bug
> Components: data type, planner/optimizer
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Priority: Blocker
> Fix For: 0.9.1
>
> Attachments: TAJO-1234.patch, TAJO-1234_2.patch, TAJO-1234_3.patch,
> TAJO-1234_4.patch, TAJO-1234_5.patch, TAJO-1234_6.patch
>
>
> Currently, the master branch causes unit test failures. It's because that
> some inconsistent timezone usages. The main purpose of this issue is to
> cleanup and rearrange timezone usages.
> I discussed this issue with [~jungjw] at
> * http://markmail.org/thread/qhsizgp2pnd6swjq
> * http://markmail.org/message/3nqecl34l2ayxg2x
> I'll fix some parts as I mentioned in above mailing list threads.
> In sum,
> * Tajo will have only four points which consider timezone:
> ** query statement
> ** Input table
> ** text printout in TajoCli
> ** Casting from text to either time or timestamp
> * All other parts have to deal with TIME and TIMESTAMP values as UTC value
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
