Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/289#discussion_r21501546
--- Diff:
tajo-storage/src/main/java/org/apache/tajo/storage/text/ByteBufLineReader.java
---
@@ -147,19 +155,19 @@ public ByteBuf readLineBuf(AtomicInteger reads)
throws IOException {
//does not appeared terminating newline
buffer.readerIndex(buffer.writerIndex()); // set to end buffer
if(eof){
- readBytes = buffer.readerIndex() - startIndex;
- newlineLength = 0;
+ readBytes += buffer.readerIndex() - startIndex;
break loop;
}
} else {
buffer.readerIndex(endIndex + 1);
- readBytes = buffer.readerIndex() - startIndex;
+ readBytes += (buffer.readerIndex() - startIndex);
if (processor.isPrevCharCR() && buffer.isReadable()
--- End diff --
Could you add comments about this condition?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
