Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/288#issuecomment-66479977
Hi @babokim,
I really appreciate your contribution. It's really great work. This work
also includes the beginning of generic storage plugin. It's a nice starting
work.
I have one comment. In this patch, tajo-common/org.apache.tajo.json is
moved org.apache.tajo.storage.json. Although it's not related to the purpose of
this issue, this move touches lots of files. It's because GsonObject and
CommonGsonHelper are widely used in the system.
So, I'd like to suggest move back it to org.apache.tajo.json. If necessary,
we can do it in another jira.
Also, as I mentioned above, this patch needs rebase.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
