[
https://issues.apache.org/jira/browse/TAJO-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242653#comment-14242653
]
ASF GitHub Bot commented on TAJO-1241:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/295#discussion_r21681310
--- Diff:
tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java ---
@@ -258,11 +232,10 @@ public String call(NettyClientBase client) throws
ServiceException {
}.withRetries();
}
- public String getCachedSessionVariable(final String varname) {
- if (sessionVarsCache.containsKey(varname)) {
- return sessionVarsCache.get(varname);
- } else {
- throw new RuntimeException("No such session variable" + varname);
+ void updateSessionVarsCache(Map<String, String> variables) {
+ synchronized (sessionVarsCache) {
+ this.sessionVarsCache.clear();
--- End diff --
I wonder why all cached variables are cleared before update.
Whenever a set command is executed, a new hash map instance is passed from
the client.
(Please see SetCommand.updateSessionVariable().)
> Change default client and table time zone behavior
> --------------------------------------------------
>
> Key: TAJO-1241
> URL: https://issues.apache.org/jira/browse/TAJO-1241
> Project: Tajo
> Issue Type: Improvement
> Components: storage
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.9.1
>
> Attachments: TAJO-1241.patch, TAJO-1241_2.patch, TAJO-1241_3.patch
>
>
> By default, TajoClient uses GMT as client time zone unless session variable
> {{TIMEZONE}} is specified. Also, by default Table uses GMT as table time zone
> unless table property {{timezone}} is specified.
> This patch changes these default behavior as follows:
> * TajoClient will use {{TimeZone.getDefault()}} by default.
> * Table implicitly uses tajo.timezone by default.
> * In other words, this default time zone does not affect the table
> property in catalog.
> I also added the documentation about time zone.
> http://people.apache.org/~hyunsik/timezone/time_zone.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
