[ 
https://issues.apache.org/jira/browse/TAJO-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243841#comment-14243841
 ] 

ASF GitHub Bot commented on TAJO-1221:
--------------------------------------

Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/286#discussion_r21731837
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/master/ha/HAServiceHDFSImpl.java ---
    @@ -169,6 +174,48 @@ private void createMasterFile(boolean isActive) throws 
IOException {
       }
     
     
    +  private String getHostName(String hostAddress, int type) {
    +    String hostName = null;
    +    int port = 0;
    +
    +    switch (type) {
    +      case HAConstants.MASTER_UMBILICAL_RPC_ADDRESS:
    +        hostName = 
context.getConf().get(TajoConf.ConfVars.TAJO_MASTER_UMBILICAL_RPC_ADDRESS
    +          .varname);
    +        port = 26001;
    --- End diff --
    
    The port is hard coded. any have reason ?


> HA TajoClient should not connect TajoMaster at the first.
> ---------------------------------------------------------
>
>                 Key: TAJO-1221
>                 URL: https://issues.apache.org/jira/browse/TAJO-1221
>             Project: Tajo
>          Issue Type: Improvement
>          Components: tajo master
>            Reporter: Hyunsik Choi
>            Assignee: Jaehwa Jung
>              Labels: failure-handling, fault-tolerance, high-availability
>             Fix For: 0.9.1
>
>
> *Problem*
> We TajoClient is opened, TajoClient initially tries to connect TajoMaster. 
> This manner does not guarantee high availability. A known TajoMaster host may 
> be not work anymore. So, this manner still has some failure point.
> Also, this manner prohibits a Tajo cluster to run on some dynamic cluster 
> environments like Yarn.
> *Solution*
> Tajo HA client should get directly TajoMaster addresses and others from HA 
> component without contacting TajoMaster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to