[
https://issues.apache.org/jira/browse/TAJO-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255052#comment-14255052
]
ASF GitHub Bot commented on TAJO-1261:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/312#discussion_r22146002
--- Diff:
tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
---
@@ -390,8 +392,8 @@ public synchronized void startQuery() {
optimizer.optimize(queryContext, plan);
- GlobalEngine.DistributedQueryHookManager hookManager = new
GlobalEngine.DistributedQueryHookManager();
- hookManager.addHook(new GlobalEngine.InsertHook());
+ DistributedQueryHookManager hookManager = new
DistributedQueryHookManager();
+ hookManager.addHook(new InsertIntoHook());
--- End diff --
Both QueryExecutor and QueryMasterTask have the DistributedQueryHookManager.
So, it would be better to maintain it in only one module.
Since this is not a big change, I think that we can fix this in this issue.
IMHO, QueryMasterTask is the proper one.
What do you think?
> Separate query and ddl execution codes from GlobalEngine
> --------------------------------------------------------
>
> Key: TAJO-1261
> URL: https://issues.apache.org/jira/browse/TAJO-1261
> Project: Tajo
> Issue Type: Improvement
> Components: tajo master
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.10
>
> Attachments: TAJO-1261.patch
>
>
> This is a code cleanup issue. The patch separates query execution, ddl
> execution, and hooks from GlobalEngine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
