[ 
https://issues.apache.org/jira/browse/TAJO-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260721#comment-14260721
 ] 

Tajo QA commented on TAJO-1228:
-------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12689424/TAJO-1228_4.patch
  against master revision release-0.9.0-rc0-112-gfd49bff.

    {color:green}+1 @author.{color}  The patch does not contain any @author 
tags.

    {color:green}+1 tests included.{color}  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac.{color}  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the 
total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 176 new 
Findbugs (version 2.0.3) warnings.

    {color:red}-1 release audit.{color}  The applied patch generated 299 
release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in 
tajo-client tajo-core.

Test results: 
https://builds.apache.org/job/PreCommit-TAJO-Build/563//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/563//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/563//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/563//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/563//console

This message is automatically generated.

> TajoClient should communicate with only TajoMaster without TajoWorker
> ---------------------------------------------------------------------
>
>                 Key: TAJO-1228
>                 URL: https://issues.apache.org/jira/browse/TAJO-1228
>             Project: Tajo
>          Issue Type: Bug
>          Components: client
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.10
>
>         Attachments: TAJO-1228.patch, TAJO-1228_2.patch, TAJO-1228_3.patch, 
> TAJO-1228_4.patch
>
>
> Currently, TajoClient connects with TajoMaster as well as TajoWorker. A query 
> submission is passed from TajoClient to TajoMaster, and than TajoMaster 
> forwards the query to one query master running on a TajoWorker. After than, a 
> client monitors the query progress through the query master.
> In other words, TajoClient contacts both TajoMaster and TajoWorker. It has 
> three disadvantages:
>  * a network firewall should allow connections to TajoWorker nodes.
>  * all components should have complex states and communication logic one 
> another. 
>  * TAJO-1160 is trying to remove hadoop dependency from TajoClient. In 
> TAJO-1160, TajoClient will use only some server which forwards query results 
> to itself instead of reading directly HDFS. TajoMaster would be the best 
> component to forward the query results because TajoClient always connects 
> with TajoMaster. So, if TajoClient communicates with only TajoMaster, all 
> client logic and protocol would be simple.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to