[ 
https://issues.apache.org/jira/browse/TAJO-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260858#comment-14260858
 ] 

ASF GitHub Bot commented on TAJO-269:
-------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/322#discussion_r22339914
  
    --- Diff: 
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
 ---
    @@ -199,6 +199,12 @@ private RuntimeException 
throwAmbiguousFieldException(Collection<Integer> idList
       }
        
        public int getColumnId(String name) {
    +    // if the same column exists, immediately return that column.
    +    if (fieldsByQualifiedName.containsKey(name)) {
    --- End diff --
    
    The same condition is checked at Line 210.
    Furthermore, the below line also checks whether the given name is qualified 
or not.


> Protocol buffer De/Serialization for LogicalNode
> ------------------------------------------------
>
>                 Key: TAJO-269
>                 URL: https://issues.apache.org/jira/browse/TAJO-269
>             Project: Tajo
>          Issue Type: Improvement
>          Components: query master, worker
>            Reporter: Jihoon Son
>            Assignee: Hyunsik Choi
>             Fix For: 0.10
>
>         Attachments: TAJO-269.patch, TAJO-269_2.patch
>
>
> In the current implementation, the logical plan is serialized into a JSON 
> object and sent to each worker.
> However, the transmission of JSON object incurs the high overhead due to its 
> large size.
> ProtocolBuffer is a good alternative because its overhead is quite small and 
> already used in other modules of Tajo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to