[ 
https://issues.apache.org/jira/browse/TAJO-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269510#comment-14269510
 ] 

ASF GitHub Bot commented on TAJO-1258:
--------------------------------------

GitHub user eminency opened a pull request:

    https://github.com/apache/tajo/pull/340

    TAJO-1258: Close() for classes derived from FileAppender should be robust

    TAJO-1258 branch is newly created and PR is re-created.
    
    I modified it using IOUtils.cleanup.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eminency/tajo TAJO-1258

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #340
    
----
commit c0f3f4f0f996352737ffa40e428437d77f1a2cd2
Author: Jongyoung Park <[email protected]>
Date:   2015-01-08T16:22:44Z

    IOUtils.cleanup is used instead of direct close() in appenders.

----


> Close() for classes derived from FileAppender should be robust
> --------------------------------------------------------------
>
>                 Key: TAJO-1258
>                 URL: https://issues.apache.org/jira/browse/TAJO-1258
>             Project: Tajo
>          Issue Type: Improvement
>          Components: storage
>    Affects Versions: 0.9.0
>            Reporter: Jongyoung Park
>            Assignee: Jongyoung Park
>             Fix For: 0.10
>
>
> As I investigated, many appenders have possibility to cause NPE such as 
> TAJO-1227.
> It seems checking null for each variables is ineffective.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to