Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/384#discussion_r25909557
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
---
@@ -1963,7 +1964,7 @@ public static boolean
checkIfBeEvaluatedAtGroupBy(EvalNode evalNode, GroupbyNode
}
public static boolean checkIfBeEvaluatedAtJoin(QueryBlock block,
EvalNode evalNode, JoinNode node,
- boolean isTopMostJoin) {
+ boolean isOnPredicate) {
--- End diff --
```isOnPredicate``` seems to be a flag to indicate if a predicate is ON
clause?
But, it seems to be inconsistent with its usecases. In
ProjectionPushDownRule, TRUE is given to this parameter. But, in the line 1153,
this value is true even though they are not placed ON clause.
Could you let me know your exact intention about this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
