[ 
https://issues.apache.org/jira/browse/TAJO-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360026#comment-14360026
 ] 

ASF GitHub Bot commented on TAJO-1391:
--------------------------------------

Github user ykrips commented on the pull request:

    https://github.com/apache/tajo/pull/412#issuecomment-78837635
  
    Client does not check the connection status. Can you check this exception?
    ```
    com.google.protobuf.ServiceException: 
org.apache.tajo.rpc.TajoServiceException: 
java.nio.channels.ClosedChannelException
            at 
org.apache.tajo.rpc.BlockingRpcClient$ProxyRpcChannel.callBlockingMethod(BlockingRpcClient.java:115)
            at 
org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$BlockingStub.getAllDatabases(TajoMasterClientProtocol.java:2163)
            at 
org.apache.tajo.client.CatalogAdminClientImpl$4.call(CatalogAdminClientImpl.java:106)
            at 
org.apache.tajo.client.CatalogAdminClientImpl$4.call(CatalogAdminClientImpl.java:100)
            at 
org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:94)
            at 
org.apache.tajo.client.CatalogAdminClientImpl.getAllDatabaseNames(CatalogAdminClientImpl.java:99)
            at 
org.apache.tajo.client.TajoClientImpl.getAllDatabaseNames(TajoClientImpl.java:186)
            at 
org.apache.tajo.client.TestTajoClient.testSelectDatabaseToInvalidOne(TestTajoClient.java:145)
    ```


> RpcConnectionPool should check reference counter of connection before close
> ---------------------------------------------------------------------------
>
>                 Key: TAJO-1391
>                 URL: https://issues.apache.org/jira/browse/TAJO-1391
>             Project: Tajo
>          Issue Type: Improvement
>          Components: rpc
>            Reporter: Navis
>            Assignee: Navis
>
> Connections in the pool is shared one and should be closed only when it's not 
> referenced by other threads. Furthermore, current pool implementation locks 
> whole connections for connecting/closing a connection, making bad 
> interferences on other operations (on sane connection).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to