Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/448#discussion_r27023446
--- Diff:
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java
---
@@ -50,15 +73,21 @@ public PartitionDesc(CatalogProtos.PartitionDescProto
proto) {
if(proto.hasPartitionName()) {
this.partitionName = proto.getPartitionName();
}
- this.ordinalPosition = proto.getOrdinalPosition();
- if(proto.hasPartitionValue()) {
- this.partitionValue = proto.getPartitionValue();
+
+ this.partitionKeys = new ArrayList<PartitionKey>();
+ for(CatalogProtos.PartitionKeyProto keyProto :
proto.getPartitionKeysList()) {
+ PartitionKey partitionKey = new PartitionKey(keyProto);
+ this.partitionKeys.add(partitionKey);
}
+
if(proto.hasPath()) {
this.path = proto.getPath();
}
}
+ public String getPartitionName() { return partitionName; }
+ public void setPartitionName(String partitionName) { this.partitionName
= partitionName; }
--- End diff --
Is this function different with the below setName() function?
In addition, please move brackets according to our coding convention.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
