Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/473#issuecomment-87281813
The patch looks good to me.
I have one suggestion. You make new EvalNode Type ```PYTHON_FUNCTION```.
But, it may be not matched to the design of EvalNode, and it will require
duplicated codes for EvalNode visitors.
You seem to do because Python function involcation is different from
existing Java function. I think that the best solution is to separate EvalNode
and Function Invocation code. In more detail, you should implement some
function invocation interface, and separate java function invocation and python
function invocation. Each function invocation implementation can be
initialized at the first function call, or you can use EvalNode::Bind(), being
addressed in TAJO-1436.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
