[ 
https://issues.apache.org/jira/browse/TAJO-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387756#comment-14387756
 ] 

ASF GitHub Bot commented on TAJO-1462:
--------------------------------------

Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/475#issuecomment-87891801
  
    Thanks for your contribution. I have two comments. 
    - If any options are given, the delimiter of text files is ','. I think 
that we need at least one example without the delimiter option. 
    - You modified the document for the csv file. However, that document still 
looks to explain how to use csv files. So, it would be better to change the 
document title together. 


> Replace CSV examples into TEXT examples in docs
> -----------------------------------------------
>
>                 Key: TAJO-1462
>                 URL: https://issues.apache.org/jira/browse/TAJO-1462
>             Project: Tajo
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Trivial
>             Fix For: 0.10.1
>
>         Attachments: TAJO-1462.Hyun.150328.0.patch.txt
>
>
> To guide users to move from CSV into TEXT storage type, this issue propose to 
> replace CSV examples into TEXT examples.
> * Case 1: An example with no delimiter definition
> {code:sql}
> - USING CSV
> + USING TEXT WITH ('textfile.delimiter'=',')
> {code}
> * Case 2: An example with text delimiter definition
> {code:sql}
> - USING CSV WITH('text.delimiter'='\u0001',...)
> + USING TEXT WITH('text.delimiter'='\u0001',...)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to