[
https://issues.apache.org/jira/browse/TAJO-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395452#comment-14395452
]
ASF GitHub Bot commented on TAJO-1452:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/470#issuecomment-89479972
Hi @dongjoon-hyun,
Unfortunately, I don't have enough time to review this patch. Nevertheless,
I greatly appreciate your recent contributions.
Besides, I'm going to give you some useful suggestion. You may close the
previous PR (https://github.com/apache/tajo/pull/469) and open this PR in order
to rebase or update the patch.
Actually, you don't need to close and open new PR for each update. You can
update an existing PR by just pushing some changes to the branch used for the
existing PR. I hope that my advice would be helpful to your contribution.
> Improve function listing order
> ------------------------------
>
> Key: TAJO-1452
> URL: https://issues.apache.org/jira/browse/TAJO-1452
> Project: Tajo
> Issue Type: Improvement
> Components: cli, web UI
> Reporter: Dongjoon Hyun
> Assignee: Dongjoon Hyun
> Priority: Trivial
> Fix For: 0.10.1
>
> Attachments: TAJO-1452.Hyun.150327.0.patch.txt, after_lag.png,
> before_lag.png
>
>
> Tajo shows users function list in two places(CLI,Web) in only alphabetical
> `function name` and emunerical(not alphabetical) `result type` order. This
> issue propose to display them in full alphabetical `function name`, `type`,
> `result type', 'argument type' order.
> *tsql*
> {code}
> default> \df sum
> Name | Result type | Argument types | Description
> | Type
> -----------------+-----------------+-----------------------+-----------------------------------------------+-----------
> sum | INT8 | int4 | the sum of a set
> of numbers | AGGREGATIO
> sum | INT8 | int8 | the sum of a set
> of numbers | AGGREGATIO
> sum | INT8 | int8 | the sum of a
> distinct and non-null values | DISTINCT_A
> sum | INT8 | int4 | the sum of a
> distinct and non-null values | DISTINCT_A
> sum | FLOAT8 | float8 | the sum of a
> distinct and non-null values | DISTINCT_A
> sum | FLOAT8 | float4 | the sum of a
> distinct and non-null values | DISTINCT_A
> sum | FLOAT8 | float8 | the sum of a set
> of numbers | AGGREGATIO
> sum | FLOAT8 | float4 | the sum of a set
> of numbers | AGGREGATIO
> {code}
> {code}
> default> \df sum
> Name | Result type | Argument types | Description
> | Type
> -----------------+-----------------+-----------------------+-----------------------------------------------+-----------
> sum | float8 | float4 | the sum of a set
> of numbers | aggregatio
> sum | float8 | float8 | the sum of a set
> of numbers | aggregatio
> sum | int8 | int4 | the sum of a set
> of numbers | aggregatio
> sum | int8 | int8 | the sum of a set
> of numbers | aggregatio
> sum | float8 | float4 | the sum of a
> distinct and non-null values | distinct_a
> sum | float8 | float8 | the sum of a
> distinct and non-null values | distinct_a
> sum | int8 | int4 | the sum of a
> distinct and non-null values | distinct_a
> sum | int8 | int8 | the sum of a
> distinct and non-null values | distinct_a
> {code}
> `http://localhost:26080/functions.jsp` will change the result in the same
> order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
