Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/442#discussion_r27835860
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java 
---
    @@ -143,6 +148,18 @@ private QueryContext createQueryContext(Session 
session) {
           newQueryContext.putAll(CommonTestingUtil.getSessionVarsForTest());
         }
     
    +    // Set queryCache in session
    +    if (session.getQueryCache() == null) {
    +      session.setQueryCache(CacheBuilder.newBuilder()
    +        .maximumSize(200)
    --- End diff --
    
    That's a good idea. No problem. By the way, the weight should be estimated 
by SQL query string length, right? Or, do you have some Util to measure Expr 
memory consumption? Up to now, I can not find that kind of code in Expr. Do you 
think SQL query string length is okay?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to