Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/601#discussion_r32494311
  
    --- Diff: 
tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java
 ---
    @@ -892,9 +892,8 @@ protected Path commitOutputData(OverridableConf 
queryContext, boolean changeFile
               boolean movedToOldTable = false;
               boolean committed = false;
               Path oldTableDir = new Path(stagingDir, 
TajoConstants.INSERT_OVERWIRTE_OLD_TABLE_NAME);
    -          ContentSummary summary = fs.getContentSummary(stagingResultDir);
     
    -          if (!queryContext.get(QueryVars.OUTPUT_PARTITIONS, "").isEmpty() 
&& summary.getFileCount() > 0L) {
    +          if (!queryContext.get(QueryVars.OUTPUT_PARTITIONS, 
"").isEmpty()) {
    --- End diff --
    
    It would be better if it works according to session variable to allow users 
to decide whether original data set is removed or not when inserting rows is 
empty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to