[ 
https://issues.apache.org/jira/browse/TAJO-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598705#comment-14598705
 ] 

ASF GitHub Bot commented on TAJO-1644:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/601#discussion_r33110852
  
    --- Diff: tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java ---
    @@ -376,7 +375,10 @@ public static int setDateOrder(int dateOrder) {
         // Behavior Control 
---------------------------------------------------------
         $BEHAVIOR_ARITHMETIC_ABORT("tajo.behavior.arithmetic-abort", false),
     
    -    // ResultSet ---------------------------------------------------------
    +    // When inserting empty data into a partitioned table, set to keep 
existing data.
    +    
$TABLE_PARTITION_KEPT_EXISTING_DATA_ENABLED("tajo.table-partition.kept-existing-data.enabled",
 true),
    --- End diff --
    
    This also should be updated by my above comment. Also, it would be nice if 
the config key is changed to 'tajo.partition.overwrite.even-if-no-result', and 
its default config should be ``false``.


> When inserting empty data into a partitioned table, existing data would be 
> removed.
> -----------------------------------------------------------------------------------
>
>                 Key: TAJO-1644
>                 URL: https://issues.apache.org/jira/browse/TAJO-1644
>             Project: Tajo
>          Issue Type: Bug
>          Components: query master
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>             Fix For: 0.11.0, 0.10.2
>
>         Attachments: TAJO-1644.patch, TAJO-1644_2.patch
>
>
> When inserting empty data into a partitioned table, existing data would be 
> removed. Tajo provides column value partition which is hive-style partition. 
> In hive, when inserting empty data into a partition, there are two cases. If 
> you use dynamic partitions, existing data never would be removed. But if you 
> don't use dynamic partitions, existing data would be removed. When inserting 
> a data to partition, tajo user don't specify each column and each column 
> value. So, it is similar to dynamic partition of hive. It seems to update 
> deletion logic of partitioned table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to