Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/613#discussion_r33420399
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java
 ---
    @@ -167,23 +162,55 @@ public void init() throws IOException {
           projected = outSchema;
         }
     
    -    initScanner(projected);
    -    super.init();
    -
    -    if (plan.hasQual()) {
    -      if (scanner.isProjectable()) {
    -        qual.bind(context.getEvalContext(), projected);
    -      } else {
    -        qual.bind(context.getEvalContext(), inSchema);
    -      }
    +    return projected;
    +  }
     
    +  private void initScanIterator() {
    +    // We should use FilterScanIterator only if underlying storage does 
not support filter push down.
    --- End diff --
    
    You seem to want to use an unified interface for both index scanner and 
this work. I'm going to add the storage-related method to determine sub filter 
expressions which can be push down into a specific storage. Index scanner will 
be affected by this method in the same manner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to