[ 
https://issues.apache.org/jira/browse/TAJO-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604581#comment-14604581
 ] 

ASF GitHub Bot commented on TAJO-1658:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/613#discussion_r33420399
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java
 ---
    @@ -167,23 +162,55 @@ public void init() throws IOException {
           projected = outSchema;
         }
     
    -    initScanner(projected);
    -    super.init();
    -
    -    if (plan.hasQual()) {
    -      if (scanner.isProjectable()) {
    -        qual.bind(context.getEvalContext(), projected);
    -      } else {
    -        qual.bind(context.getEvalContext(), inSchema);
    -      }
    +    return projected;
    +  }
     
    +  private void initScanIterator() {
    +    // We should use FilterScanIterator only if underlying storage does 
not support filter push down.
    --- End diff --
    
    You seem to want to use an unified interface for both index scanner and 
this work. I'm going to add the storage-related method to determine sub filter 
expressions which can be push down into a specific storage. Index scanner will 
be affected by this method in the same manner.


> Filter push down to underlying storages
> ---------------------------------------
>
>                 Key: TAJO-1658
>                 URL: https://issues.apache.org/jira/browse/TAJO-1658
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: physical operator, storage
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>
> Some storages can filter unqualified rows. For it, SeqScanner should support 
> the filter push down to underlying scanners.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to