[
https://issues.apache.org/jira/browse/TAJO-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631168#comment-14631168
]
ASF GitHub Bot commented on TAJO-1352:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/593#issuecomment-122240606
Thank you for your work.
I leave additional trivial comments.
* LogicalPlanRewriteRule in LogicalOptimizer is not used.
* handleRemainingFiltersIfNecessary needs a brief comment to explain its
purpose.
* JoinOrderingUtil includes several unused imports.
* The multi line comments In 63 line in GreedyHeuristicAlgorithm.java
should use ``//`` instead of ``/*``.
* GreedyHeuristicAlgorithm::prepareGraphUpdate needs a brief comment to
its purpose.
The patch seems to be ready to be committed. After your answer, I'll finish
the review.
> Improve the join order algorithm to consider missed cases of associative join
> operators
> ---------------------------------------------------------------------------------------
>
> Key: TAJO-1352
> URL: https://issues.apache.org/jira/browse/TAJO-1352
> Project: Tajo
> Issue Type: Improvement
> Components: planner/optimizer
> Reporter: Jihoon Son
> Assignee: Jihoon Son
> Attachments: JoinGraph.png
>
>
> TAJO-1277 fixes a bug related to the associativity of join operators, but
> there are still some missed cases that join operators are associative. This
> work should include the cases described in the following links:
> * http://stackoverflow.com/questions/20022196/are-left-outer-joins-associative
> * https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Joins
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
