[
https://issues.apache.org/jira/browse/TAJO-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649152#comment-14649152
]
ASF GitHub Bot commented on TAJO-1699:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/662#discussion_r35968450
--- Diff:
tajo-client/src/main/java/org/apache/tajo/client/v2/QueryFuture.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.tajo.client.v2;
+
+import org.apache.tajo.auth.UserRoleInfo;
+
+import java.sql.ResultSet;
+import java.util.concurrent.Future;
+
+public interface QueryFuture extends Future<ResultSet> {
+ /**
+ * Get a query id
+ *
+ * @return query id
+ */
+ String id();
+
+ String queue();
+
+ /**
+ * Get a query state
+ *
+ * @return query state
+ */
+ QueryState state();
+
+ /**
+ * Get a normalized progress (0 ~ 1.0f) of a query running
+ *
+ * @return progress
+ */
+ float progress();
+
+ /**
+ * A submitted or running query state is normal
+ *
+ * @return True if a query state is normal
+ */
+ boolean isOk();
+
+ /**
+ * Get whether the query is successfully completed or not.
+ *
+ * @return True if the query is successfully completed.
+ */
+ boolean isCompleted();
--- End diff --
For me, ```query is completed``` sounds that query execution is completed
whether it is succeeded, failed or killed.
How about changing ```isSucceeded()```? IMHO, it looks more intuitive.
> Tajo Java Client version 2
> --------------------------
>
> Key: TAJO-1699
> URL: https://issues.apache.org/jira/browse/TAJO-1699
> Project: Tajo
> Issue Type: Improvement
> Components: Java Client
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.11.0
>
>
> I propose Tajo Java Client version 2. Its motivations are as follows:
> * After TAJO-1625, the error propagation has been changed significantly.
> Java Client should make use the new error propagation system. Java Client
> should throw the proper exceptions.
> * Many Java API exposes internal data structure and protocol buffer data
> structure. It requires users to understand its internal behavior and
> architecture. We should hide them from users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
